mirror/rustlings
1
0
Fork 0
mirror of https://github.com/rust-lang/rustlings.git synced 2024-12-25 00:00:05 +03:00
Code Issues Packages Projects Releases Wiki Activity

Limit the amount of parallelism in check_all

Browse source 
Don't create more threads than there are CPU cores.
This commit is contained in:
Nahor 2024-10-02 14:42:50 -07:00
parent 5c17abd1bf
commit e2f7734f37
1 changed files with 25 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
src/app_state.rs
View file

@ -5,7 +5,7 @@ use std::{
io::{self, Read, Seek, StdoutLock, Write}, io::{self, Read, Seek, StdoutLock, Write},
path::{Path, MAIN_SEPARATOR_STR}, path::{Path, MAIN_SEPARATOR_STR},
process::{Command, Stdio}, process::{Command, Stdio},
sync::mpsc, sync::{atomic::AtomicUsize, mpsc, Arc},
thread, thread,
}; };
@ -20,6 +20,7 @@ use crate::{
}; };
const STATE_FILE_NAME: &str = ".rustlings-state.txt"; const STATE_FILE_NAME: &str = ".rustlings-state.txt";
const DEFAULT_CHECK_PARALLELISM: usize = 8;
#[must_use] #[must_use]
pub enum ExercisesProgress { pub enum ExercisesProgress {
@ -411,17 +412,31 @@ impl AppState {
let (mut checked_count, mut results) = thread::scope(|s| { let (mut checked_count, mut results) = thread::scope(|s| {
let (tx, rx) = mpsc::channel(); let (tx, rx) = mpsc::channel();
let exercise_ind = Arc::new(AtomicUsize::default());
self.exercises let num_core = thread::available_parallelism()
.iter() .map_or(DEFAULT_CHECK_PARALLELISM, |count| count.get());
.enumerate() (0..num_core).for_each(|_| {
.for_each(|(index, exercise)| { let tx = tx.clone();
let tx = tx.clone(); let exercise_ind = exercise_ind.clone();
let cmd_runner = &self.cmd_runner; let this = &self;
let _ = thread::Builder::new().spawn_scoped(s, move || { let _ = thread::Builder::new().spawn_scoped(s, move || {
tx.send((index, exercise.run_exercise(None, cmd_runner))) loop {
}); let exercise_ind =
exercise_ind.fetch_add(1, std::sync::atomic::Ordering::AcqRel);
let Some(exercise) = this.exercises.get(exercise_ind) else {
// No more exercises
break;
};
if tx
.send((exercise_ind, exercise.run_exercise(None, &this.cmd_runner)))
.is_err()
{
break;
}
}
}); });
});
// Drop this `tx`, since the `rx` loop will not stop while there is // Drop this `tx`, since the `rx` loop will not stop while there is
// at least one tx alive (i.e. we want the loop to block only while // at least one tx alive (i.e. we want the loop to block only while