Compare commits

..

5 commits

Author SHA1 Message Date
Kacper Poneta e6c855c18e
Merge 59e8f70e55 into dd0634c483 2024-11-14 14:38:45 -03:00
Mo dd0634c483
Merge pull request #2158 from mnshdw/mnshdw/feedback-errors6
errors6: Add alternative solution using From trait
2024-11-14 14:49:57 +01:00
Antoine Dupuis fc0cd8f0f8 Switch comment style to // 2024-11-14 09:14:40 +01:00
Antoine Dupuis d5cae8ff59 Add alternative solution using From trait 2024-11-13 23:51:09 +01:00
mo8it 38016cb2d6 clippy3: Make the intent more clear 2024-11-13 16:06:41 +01:00
3 changed files with 21 additions and 4 deletions

View file

@ -4,9 +4,11 @@
#[rustfmt::skip] #[rustfmt::skip]
#[allow(unused_variables, unused_assignments)] #[allow(unused_variables, unused_assignments)]
fn main() { fn main() {
let my_option: Option<()> = None; let my_option: Option<&str> = None;
// Assume that you don't know the value of `my_option`.
// In the case of `Some`, we want to print its value.
if my_option.is_none() { if my_option.is_none() {
println!("{:?}", my_option.unwrap()); println!("{}", my_option.unwrap());
} }
let my_arr = &[ let my_arr = &[

View file

@ -29,6 +29,21 @@ impl ParsePosNonzeroError {
} }
} }
// As an alternative solution, implementing the `From` trait allows for the
// automatic conversion from a `ParseIntError` into a `ParsePosNonzeroError`
// using the `?` operator, without the need to call `map_err`.
//
// ```
// let x: i64 = s.parse()?;
// ```
//
// Traits like `From` will be dealt with in later exercises.
impl From<ParseIntError> for ParsePosNonzeroError {
fn from(err: ParseIntError) -> Self {
ParsePosNonzeroError::ParseInt(err)
}
}
#[derive(PartialEq, Debug)] #[derive(PartialEq, Debug)]
struct PositiveNonzeroInteger(u64); struct PositiveNonzeroInteger(u64);

View file

@ -3,11 +3,11 @@ use std::mem;
#[rustfmt::skip] #[rustfmt::skip]
#[allow(unused_variables, unused_assignments)] #[allow(unused_variables, unused_assignments)]
fn main() { fn main() {
let my_option: Option<()> = None; let my_option: Option<&str> = None;
// `unwrap` of an `Option` after checking if it is `None` will panic. // `unwrap` of an `Option` after checking if it is `None` will panic.
// Use `if-let` instead. // Use `if-let` instead.
if let Some(value) = my_option { if let Some(value) = my_option {
println!("{value:?}"); println!("{value}");
} }
// A comma was missing. // A comma was missing.